[System] Fix TCP socket reuse. #2047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esdrubal
force-pushed
the
socketreuse
branch
from
f1a2bb7
to
a704304
Compare
Test checks that when setting TCP socket option ReuseAddress, it is possible to bind other sockets to the same endpoint. Covers #31557.
TCP sockets with option SocketOptionName.ReuseAddress were not working on Linux. Fixes #31557.
esdrubal
force-pushed
the
socketreuse
branch
2 times, most recently
from
4a12a03
to
79d28a7
Compare
|
Interesting @esdrubal the double bind tests failed on this one, when I did this fix during my experimenting it seemed to work fine, any ideas? |
|
@stefansedich it should work but it seems Jenkins is using a Linux distribution that doesn't support SO_REUSEPORT. It should work when |
|
@esdrubal |
esdrubal
force-pushed
the
socketreuse
branch
from
a922a73
to
8b27eba
Compare
Multiple threads listening to the same address and port are not possible before linux 3.9 kernel, where the socket option SO_REUSEPORT was introduced. This commit makes TcpDoubleBind sensible to this OS capability.
esdrubal
force-pushed
the
socketreuse
branch
from
8b27eba
to
59c7265
Compare
esdrubal
added a commit
that referenced
this pull request
Sep 17, 2015
[System] Fix TCP socket reuse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TCP sockets with option SocketOptionName.ReuseAddress were not working on Linux.
Fixes #31557.